Add support Eurotronic Spirit Z #1553
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons - No to implement the Download/Refresh Functions
Eurotronic Spirit Z
/usr/share/domoticz/open-zwave/cpp/src/command_classes/DoorLockLogging.cpp: In member function �virtual bool OpenZWave::DoorLockLogging::HandleMsg(const uint8*, uint32, uint32)�:
/usr/share/domoticz/open-zwave/cpp/src/command_classes/DoorLockLogging.cpp:312:15: error: passing argument 1 to restrict-qualified parameter aliases with argument 4 [-Werror=restrict]
snprintf(usercode, sizeof(usercode), "%s %d", usercode, (int)_data[12+i]);
^~~~~~~~ ~~~~~~~~
The changes allow the parameters to be set to their full allowable range of values, as specified in the documentation: https://homeseer.com/wp-content/uploads/2018/06/HS-WD100-Manual-6a.pdf The documentation specifies the size of parameters 7 and 9 as 1 byte, however defining them as bytes prevented OZW from updating the values: the values would always reset to 1, regardless of the supplied value. Using short works.
Fix parameter size and allowed values for HS-WD100+
Revert "Fix parameter size and allowed values for HS-WD100+"
Fix compilation error in regards to -Werror=restrict
Compilation fixes for FreeBSD
|
This in invalid. You are trying to merge our Dev and Master branches. |
|
Hi @Fishwaldo |
|
I miss it too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Support Eurotronic Spirit pull request #1387