Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create nas-wr01ze.xml #1723

Merged
merged 3 commits into from Mar 1, 2019
Merged

Create nas-wr01ze.xml #1723

merged 3 commits into from Mar 1, 2019

Conversation

Beddie
Copy link
Contributor

@Beddie Beddie commented Feb 28, 2019

If user set this parameter to default by Configure CC, the parameter #10 will be set to default value.
</Help>
</Value>
<Value type="byte" genre="config" instance="1" index="9" label="Configure power report" units="%" value="30" min="1" max="100" size="1">
Copy link

@mbronk mbronk Mar 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per this, this param may now be in cA (centiamp), with a valid range of 1-1600.
Not sure if the source of the info is reliable (a manual) or if it comes from trial and error, though it would match my own observations here

I.e. I suggest correcting the unit, range and default values to sth like:
units="cA" value="50" min="1" max="1600" (from the value range, I infer this param is now 2-byte, but this would require confirming)

EDIT: Actually, other defaults in this file may also need updating to match the values after factory reset

Copy link
Contributor Author

@Beddie Beddie Mar 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbronk Good paramter 9 suggestion, i just updated the file parameter 9 with your suggestion and changed some default values.
The sources i used to create the xml file is a combination of online references (the shipped device manual is incorrect) and trial and error.
All parameters are working (tested myself) except parameter 9 (of course this is not optimal and needs a change in the future)

Change different default values and edited parameter 9.
@Peboli
Copy link

Peboli commented Mar 1, 2019

If it may help I got this manual from Neo, it belong to this new model of power plug with S2 support.
nas-wr01z S2 SmartPlug Manual.pdf

@nechry
Copy link
Member

nechry commented Mar 1, 2019

duplicate ?
#1722

@nechry nechry mentioned this pull request Mar 1, 2019
Added information from manual "nas-wr01z S2 SmartPlug Manual.pdf"
@Beddie
Copy link
Contributor Author

Beddie commented Mar 1, 2019

The manual "nas-wr01z S2 SmartPlug Manual.pdf" is really helpfull, thanks Peboli, i just updated #1723 with information from this manual.

@Beddie
Copy link
Contributor Author

Beddie commented Mar 1, 2019

duplicate ?
#1722

@nechry Yes
#1722 and #1723 were complementary and i just merged the patches.
#1722 is leading. #1723 can be closed.

@nechry nechry merged commit 8d406d9 into OpenZWave:master Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants