Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Fibaro FGWDS221 Walli Double Switch #1869

Merged
merged 7 commits into from Jul 10, 2019
Merged

Added Fibaro FGWDS221 Walli Double Switch #1869

merged 7 commits into from Jul 10, 2019

Conversation

TerrorSource
Copy link
Contributor

@TerrorSource TerrorSource commented Jul 7, 2019

Added "FGWDS221 Walli Double Switch" to manufacturer_specifiec.xml
Added /config/fibaro/fgwds221.xml file with all z-wave config's from https://products.z-wavealliance.org/products/3395/configs

TerrorSource added 3 commits July 7, 2019 21:30
Added FGWDS221 Walli Double Switch
FGWDS221 Walli Double Switch Config file
@TerrorSource TerrorSource changed the title Added Added Fibaro FGWDS221 Walli Double Switch Jul 7, 2019
@Fishwaldo
Copy link
Member

please run make xmltest and fix up the problems it reports.

@TerrorSource
Copy link
Contributor Author

TerrorSource commented Jul 10, 2019

@Fishwaldo
Couldnt do "make xmltest"
Had to do:
sudo apt-get install libxml2-utils
sudo apt-get install libxml-simple-perl

Fixed the failures and re-uploaded the file in the PR.

"make xmltest" run:
/home/pi/open-zwave/config/manufacturer_specific.xml validates
/home/pi/open-zwave/config/fibaro/fgwds221.xml validates

Checking Config Files... Please Wait
config/fibaro/fgwds221.xml - Adding new file to Database

No errors detected (You can submit your changes to OZW)

Saving Revision Database

@petergebruers
Copy link
Collaborator

Almost there... I'll fix up the last bits for you. The "revisions" can be a moving target...

@petergebruers petergebruers merged commit c499a04 into OpenZWave:master Jul 10, 2019
@TerrorSource
Copy link
Contributor Author

@petergebruers thanks! Didn't knew i had to edit that also.
Now working on the Fibaro Walli Dimmer config. PR will be made in a few days.

@petergebruers
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants