[config] Add Intermatic PE653 and PE953 pool/spa controller and remote. #2289
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <Product Revision="1" xmlns="https://github.com/OpenZWave/open-zwave"> | ||
| <MetaData> | ||
| <MetaDataItem name="Name">PE653</MetaDataItem> | ||
| <MetaDataItem name="Description">MultiWave Five-Channel Wireless Remote Receiver</MetaDataItem> | ||
| <MetaDataItem name="OzwInfoPage">http://www.openzwave.com/device-database/0005:0653:5045</MetaDataItem> | ||
| <MetaDataItem name="ProductPic">images/intermatic/pe653.png</MetaDataItem> | ||
| <MetaDataItem id="0653" name="ZWProductPage" type="5045">https://products.z-wavealliance.org/products/89/</MetaDataItem> | ||
| <MetaDataItem id="0653" name="FrequencyName" type="5045">U.S. / Canada / Mexico</MetaDataItem> | ||
| <MetaDataItem id="0653" name="Identifier" type="5045">PE653</MetaDataItem> | ||
| <ChangeLog> | ||
| <Entry author="Jeff Brown - jeff.brown@gmail.com" date="29 June 2020" revision="1">Initial creation, tested with firmware v3.3</Entry> | ||
| </ChangeLog> | ||
| </MetaData> | ||
|
|
||
| <!-- This device must be polled. It also has a strange habit of reporting | ||
| old state when queried immediately after setting a switch and then | ||
| reporting the correct state when queried a few moments later. --> | ||
|
|
||
| <!-- This device reports 6 switches but there are only 5 circuits. | ||
| The switch on the default endpoint is redundant with endpoint 1 so | ||
| we omit it from the list of instances. --> | ||
| <CommandClass id="32"> | ||
| <Instance index="1" label="Circuit 1" /> | ||
| <Instance index="2" label="Circuit 2" /> | ||
| <Instance index="3" label="Circuit 3" /> | ||
| <Instance index="4" label="Circuit 4" /> | ||
| <Instance index="5" label="Circuit 5" /> | ||
| </CommandClass> | ||
| <CommandClass id="37"> | ||
|
There was a problem hiding this comment. This should be auto discovered. Its not needed. There was a problem hiding this comment. Per prior comment, I'm listing the switching explicitly so as to suppress a redundant instance that should not be enumerated. |
||
| <Instance index="1" label="Circuit 1" /> | ||
| <Instance index="2" label="Circuit 2" /> | ||
| <Instance index="3" label="Circuit 3" /> | ||
| <Instance index="4" label="Circuit 4" /> | ||
| <Instance index="5" label="Circuit 5" /> | ||
| <Compatibility> | ||
| <VerifyChanged index="0">true</VerifyChanged> | ||
| </Compatibility> | ||
| </CommandClass> | ||
|
|
||
| <CommandClass id="49"> | ||
|
There was a problem hiding this comment. This should be auto discovered. Its not needed. There was a problem hiding this comment. This sensor is auto-discovered but it ends up having the incorrect label and units so I'm listing it explicitly to ensure the correct information is presented to the user. |
||
| <Instance index="1" label="Water Temperature" /> | ||
| <Value type="decimal" genre="user" instance="1" index="1" label="Water Temperature" units="F"> | ||
| <Help>Water Temperature Sensor Value</Help> | ||
| </Value> | ||
| </CommandClass> | ||
|
|
||
| <CommandClass id="67"> | ||
|
There was a problem hiding this comment. This should be auto discovered. Its not needed. There was a problem hiding this comment. Unfortunately this is not the case. Auto discovery only detects instance index 1. Also, it ends up with the wrong label and units so I'm listing both thermostats explicitly to ensure the correct information is presented to the user. It took me some time to reverse engineer this. |
||
| <Instance index="1" label="Pool" /> | ||
| <Instance index="7" label="Spa" /> | ||
| <Value type="decimal" genre="user" instance="1" index="1" label="Pool" units="F"> | ||
| <Help>Set the pool water temperature setpoint</Help> | ||
| </Value> | ||
| <Value type="decimal" genre="user" instance="1" index="7" label="Spa" units="F"> | ||
| <Help>Set the spa water temperature setpoint</Help> | ||
| </Value> | ||
| </CommandClass> | ||
| </Product> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <Product Revision="1" xmlns="https://github.com/OpenZWave/open-zwave"> | ||
| <MetaData> | ||
| <MetaDataItem name="Name">PE953</MetaDataItem> | ||
| <MetaDataItem name="Description">MultiWave Five-Channel Wireless Remote Controller</MetaDataItem> | ||
| <MetaDataItem name="OzwInfoPage">http://www.openzwave.com/device-database/0005:0953:5045</MetaDataItem> | ||
| <MetaDataItem name="ProductPic">images/intermatic/pe953.png</MetaDataItem> | ||
| <MetaDataItem id="0953" name="ZWProductPage" type="5045">https://products.z-wavealliance.org/products/598/</MetaDataItem> | ||
| <MetaDataItem id="0953" name="FrequencyName" type="5045">U.S. / Canada / Mexico</MetaDataItem> | ||
| <MetaDataItem id="0953" name="Identifier" type="5045">PE953</MetaDataItem> | ||
| <ChangeLog> | ||
| <Entry author="Jeff Brown - jeff.brown@gmail.com" date="29 June 2020" revision="1">Initial creation</Entry> | ||
| </ChangeLog> | ||
| </MetaData> | ||
| </Product> | ||
|
There was a problem hiding this comment. No Config Params or Association Groups? There was a problem hiding this comment. Unfortunately the config params are very complicated and undocumented. This device is intended to be configured using the associated PE953 remote control. Having watched the traffic between the two, there's a fair bit of manufacturer specific communication going on during that process. The device doesn't support associations. |
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be auto discovered. Its not needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per the comment, this is intentional. When auto-discovered, the device presents 6 switch instances however physically there are only 5 of them. By listing them explicitly I am able to suppress the redundant switch instance and label each of them in the same manner as they appear in the product documentation.
FWIW, when I first set up the device, I got fooled by the redundant switch instance and was really confused why the switches weren't controlling the correct loads.