Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account does not allow execution simulation in v0.4.0b #471

Closed
FabijanC opened this issue Sep 14, 2022 · 0 comments · Fixed by #486
Closed

Account does not allow execution simulation in v0.4.0b #471

FabijanC opened this issue Sep 14, 2022 · 0 comments · Fixed by #486
Assignees
@ericnordelo
Labels
enhancement New feature or request

Comments

@FabijanC
Copy link

FabijanC commented Sep 14, 2022 •
edited

With Starknet v0.10.0, execution simulation has been introduced (/feeder_gateway/simulate_transaction of the sequencer API). It is used by starknet invoke --estimate_fee and starknet invoke --simulate of Starknet CLI.

This is how starknet invoke is implemented: code.
The linked function calls this one, which clearly sets version to QUERY_VERSION since query=True:

Should this line of account.cairo be changed to allow both TRANSACTION_VERSION = 1 and QUERY_VERSION = QUERY_VERSION_BASE + 1?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericnordelo ericnordelo

Labels
enhancement New feature or request
Projects
No open projects
Cairo team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow simulating calls in Account ericnordelo/cairo-contracts
3 participants
@martriay @ericnordelo @FabijanC