Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add git installation discouragement notice #480

Closed
martriay opened this issue Sep 26, 2022 · 1 comment · Fixed by #524
Closed

Add git installation discouragement notice #480

martriay opened this issue Sep 26, 2022 · 1 comment · Fixed by #524
Assignees
@andrew-fleming
Labels
documentation Improvements or additions to documentation

Comments

@martriay
Copy link
Contributor

As with Solidity contracts, we don't recommend installing directly from github since it could contain incomplete or breaking implementations (although we aim not to). Therefore, only official releases should be installed.

We should add a warning/notice in our README and documentation warning to only install through official packages.
@martriay martriay added the documentation Improvements or additions to documentation label Sep 26, 2022
@martriay
Copy link
Contributor Author

Related to software-mansion/protostar#891.

@martriay martriay added this to the after milestone Oct 22, 2022
@martriay martriay modified the milestones: after, next Nov 5, 2022
@martriay martriay modified the milestones: next, current Nov 23, 2022
@andrew-fleming andrew-fleming mentioned this issue Nov 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrew-fleming andrew-fleming

Labels
documentation Improvements or additions to documentation
Projects
No open projects
Cairo team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add warning notice for installations andrew-fleming/cairo-contracts
2 participants
@martriay @andrew-fleming