Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve account's is_valid_signature #523

Closed
martriay opened this issue Nov 24, 2022 · 1 comment
Closed

Improve account's is_valid_signature #523

martriay opened this issue Nov 24, 2022 · 1 comment
Milestone
3. after

Comments

@martriay
Copy link
Contributor

Following up on #372, Cairo's starkware.cairo.common.signature now exports a check_ecdsa_signature function that returns instead of reverting, allowing us to implement the desired version of isValidSignature in account contracts.

https://github.com/starkware-libs/cairo-lang/blob/9889fbd522edc5eff603356e1912e20642ae20af/src/starkware/cairo/common/signature.cairo#L32-L34
@juniset juniset mentioned this issue Dec 7, 2022
Closed
@martriay martriay added this to the later milestone Dec 26, 2022
@martriay martriay modified the milestone: later Jan 28, 2023
@martriay
Copy link
Contributor Author

Closing this since it will not be relevant anymore after the ongoing Cairo 1.0 migration. If you think this is a mistake, feel free to open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Cairo team
Status: ✅ Resolved
Milestone
3. after
Development

No branches or pull requests
1 participant
@martriay