Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ethernaut to use ZeppelinOS #94

Closed
theethernaut opened this issue Oct 19, 2018 · 2 comments
Closed

Update Ethernaut to use ZeppelinOS #94

theethernaut opened this issue Oct 19, 2018 · 2 comments

Comments

@theethernaut
Copy link
Contributor

Three strong reasons to do this:

(1) Right now, if a bug is discovered in a level, the code needs to be fixed and the level re-deployed.

Ethernaut remembers which levels a player has passed, so this would mean that all history for a level is lost when it is re-deployed.

(2) Also, as Solidity matures, the levels will contain old code. It'd be nice to be able to update pragma versions on a level without losing history.

(3) And finally, newer levels will likely want to use newer dependencies like OpenZeppelin 2.x, which introduce breaking changes for contracts with old code. So, unless the code in these old contracts can be updated, Ethernaut's OpenZeppelin dependency has to remain at 1.x.

@ghost
Copy link

ghost commented Apr 27, 2019

I'll take this issue on.

@frangio
Copy link
Contributor

frangio commented Sep 17, 2021

ZeppelinOS is no longer under development. 🙂

@frangio frangio closed this as completed Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants