Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add require statements to ERC777 internal functions #2208

Closed
nventuro opened this issue Apr 21, 2020 · 0 comments · Fixed by #2213
Closed

Add require statements to ERC777 internal functions #2208

nventuro opened this issue Apr 21, 2020 · 0 comments · Fixed by #2213
Labels

Comments

@nventuro
Copy link
Contributor

#2027 made some functions, including _approve, internal. A comment indicated that doing this required that a commented-out require statement be restored, but this was not done.

This leads to some of the arguments of these internal functions not being properly validated, including allowing for _approve's holder to be the zero address. We should:

  1. restore this require statement
  2. evaluate which arguments of the other functions made internal in that PR should be validated
  3. and backport the fix to v2.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant