Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPDX license identifiers missing #2234

Closed
wbt opened this issue May 14, 2020 · 2 comments · Fixed by #2235
Closed

SPDX license identifiers missing #2234

wbt opened this issue May 14, 2020 · 2 comments · Fixed by #2235

Comments

@wbt
Copy link

wbt commented May 14, 2020

As of today (Solidity 0.6.8, from this PR), Solidity issues warnings on all OpenZeppelin (and other) contracts for lack of an "SPDX-License-Identfier" code comment at the top of the file.

A proposed fix would be to add
//SPDX-License-Identifier: MIT
to the start of every contract file.

@wbt
Copy link
Author

wbt commented Jun 8, 2020

Any chance of putting out a patch release with this in it?

@nventuro
Copy link
Contributor

nventuro commented Jun 8, 2020

That's a great suggestion @wbt, thanks! I just published v3.0.2 with that change, you should be able to install it from npm now and not get any warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants