Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment in contracts #3026

Closed
vittominacori opened this issue Dec 15, 2021 · 3 comments · Fixed by #3033
Closed

Comment in contracts #3026

vittominacori opened this issue Dec 15, 2021 · 3 comments · Fixed by #3033

Comments

@vittominacori
Copy link
Contributor

Release version in each contract cause a very bad compare view v4.4.0...v4.4.1.

It seems that 141 files changed but only that comment changed.

I think that it could be better to not to have this in each contract. It adds explicit version in each file but lot of redundancy.

@Amxx
Copy link
Collaborator

Amxx commented Dec 15, 2021

it is on our roadmap to detect which file has been modified since the last release, and only bump these one.

@frangio
Copy link
Contributor

frangio commented Dec 16, 2021

Polluting the compare view is a good point we didn't consider. We're looking into this now.

I'm curious @vittominacori, in what situations do you use the compare view?

@vittominacori
Copy link
Contributor Author

I use after each new release to see what is changing in order to update my contracts if they use something you updated.

Anyway I have some projects where I use flattened code so also changing nothing it results as lot of code changes when just updating open-zeppelin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants