Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pragma for Address.sol util to ^0.8.1 upwards #3031

Closed
koolamusic opened this issue Dec 16, 2021 · 1 comment · Fixed by #3098
Closed

Update pragma for Address.sol util to ^0.8.1 upwards #3031

koolamusic opened this issue Dec 16, 2021 · 1 comment · Fixed by #3098

Comments

@koolamusic
Copy link

Referencing this PR #3025 as @axic had mentioned In 0.8.0 version of solidity the account.code.length syntax is supported, but the compiler does not have the shortcut implemented. This means it will first extcodecopy the entire target contract and measure size afterwards.

Following the guidelines with pragma version in OZ, my recommendation would be to create a new PR to update the pragma to ^0.8.1
cc @Amxx

@frangio
Copy link
Contributor

frangio commented Dec 16, 2021

From #3025 (comment):

My vote in this particular case is to bump this pragma to 0.8.1.

  • It's always good to remove assembly.
  • 0.8.1 is already almost a year old, I expect most users on 0.8 are using newer versions.
  • 0.8.0 to 0.8.1 is unlikely to be very disruptive.

It should be noted as a breaking change in the changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants