Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loss of unused Ether in meta-transaction #3664

Closed
aaaooie opened this issue Aug 31, 2022 · 1 comment · Fixed by #4346
Closed

Loss of unused Ether in meta-transaction #3664

aaaooie opened this issue Aug 31, 2022 · 1 comment · Fixed by #4346
Milestone

Comments

@aaaooie
Copy link

aaaooie commented Aug 31, 2022

In the MinimalForwarder.execute(ForwardRequest req, bytes signature) payable function, the msg.value may contain more Ether than specified in req.value. In this case (since only req.value is transferred further), the unused amount of Ether will remain on the contract address.

@frangio
Copy link
Contributor

frangio commented Aug 31, 2022

Thank you @aaaooie. As mentioned in the comments:

* MinimalForwarder is mainly meant for testing, as it is missing features to be a good production-ready forwarder. This
* contract does not intend to have all the properties that are needed for a sound forwarding system. A fully
* functioning forwarding system with good properties requires more complexity. We suggest you look at other projects
* such as the GSN which do have the goal of building a system like that.

MinimalForwarder is inded too minimal. So much so I think we might be better off removing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants