Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow reinitializer versions greater than 256 #3924

Closed
frangio opened this issue Jan 3, 2023 · 0 comments · Fixed by #4460
Closed

Allow reinitializer versions greater than 256 #3924

frangio opened this issue Jan 3, 2023 · 0 comments · Fixed by #4460
Labels
breaking change Changes that break backwards compatibility of the public API.

Comments

@frangio
Copy link
Contributor

frangio commented Jan 3, 2023

To maintain storage compatibility with the original Initializable, we made reinitializer versions of type uint8. We could use a larger type here once we break compatibility. It still makes sense to pack the value with the initializing boolean, so it can't be more than uint248, but even that sounds like an exaggeration and we might want to make it a smaller value like uint64 for the possibility of adding some other values in the same storage slot in the future.

Suggested in #3870.

@frangio frangio added the breaking change Changes that break backwards compatibility of the public API. label Jan 3, 2023
@frangio frangio added this to the 5.0 milestone Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Changes that break backwards compatibility of the public API.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant