Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code don't work at TransparentUpgradeableProxy #4809

Closed
stanta opened this issue Dec 26, 2023 · 4 comments
Closed

Code don't work at TransparentUpgradeableProxy #4809

stanta opened this issue Dec 26, 2023 · 4 comments

Comments

@stanta
Copy link

stanta commented Dec 26, 2023

Hi, @ernestognw!

At code, you updated:

_admin = address(new ProxyAdmin(initialOwner));

What did you mean as _admin = address(new ProxyAdmin(initialOwner)); ?
This don't work!
In prev version was:
_admin = admin_ (or initialOwner in this version)

Check, please!

@ernestognw
Copy link
Member

Hey, we'll appreciate if you provide a reproducible example of how this doesn't work.

From the changelog:

TransparentUpgradeableProxy: Admin is now stored in an immutable variable (set during construction) to avoid unnecessary storage reads on every proxy call. This removed the ability to ever change the admin. Transfer of the upgrade capability is exclusively handled through the ownership of the ProxyAdmin. (#4354)

@stanta
Copy link
Author

stanta commented Dec 26, 2023

Sorry, I can't, project under NDA.
But you can just switch on your logic, if have, of course...
What address will be stored as _admin in your code?

@ernestognw
Copy link
Member

But you can just switch on your logic, if have, of course...

Unfortunately, we can't, it's breaking backwards compatibility.

What address will be stored as _admin in your code?

The address of a new ProxyAdmin whose owner is _initialOwner. You can find more info in the docs.

Sorry, I can't, project under NDA.

Given no example is provided, I'm closing.

@stanta
Copy link
Author

stanta commented Dec 26, 2023

Now, new address will be address of new ProxyAdmin(initialOwner) )))
you are really programmer?
please patch code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants