New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename 'anyone' account in tests to something else #1357
Comments
How about |
what about |
I think |
Hmm, I like |
My vote is on |
I'd like to try and help work on this |
I'll probably need a bit of guidance though - are we looking to change all references in anyone to "other" in the tests, or only in some specific instances, or only in the description? |
I think just the account name: test descriptions to go 'tokens can be transferred to anyone' are actually correct (assuming anyone is no-none 😛). |
👍 got it. @nventuro, am I changing each instance of In other words, I'm only changing this:
to
|
Correct! I don't think we want to leave any instance of |
Got it. @nventuro - You can see my first attempt here: #1718 I changed all the references of "anyone" in the code to "other" and I'm pretty confident I didn't miss any. Just not sure if I might have done a few that weren't meant to have changed. I think I noticed one instance where "other" was declared but never actually used. I could remove that if you'd like. |
When testing access control related functionality, we usually have an
anyone
account that represents an account with no special permissions, e.g.:anyone
is probably not the best name we can find, we should find something that better conveys the meaning of 'anyone else', 'any random account', etc.The text was updated successfully, but these errors were encountered: