Remove ERC827 token. #1045
Merged
Remove ERC827 token. #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementing this token is unsafe as per comments here: ethereum/EIPs#827 (comment)
|
@frangio Can we merge this and potentially save someone from using unsafe code? |
|
@mg6maciej I wanted to coordinate with @AugustoL before doing this. He has now moved the code to windingtree/erc827. I will announce and explain this removal next week in the release notes for 1.11.0. Thanks for the PR! |
frangio
approved these changes
Jun 28, 2018
|
@frangio I was also discussing this with Augusto and convinced him to put a big warning unsafe at the top of his ethereum/EIPs#827 proposal. Thanks for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1044
🚀 Description
Implementing this token is unsafe as per comments here:
ethereum/EIPs#827 (comment)
npm run lint:all:fix).