Signed SafeMath #1559
Merged
Signed SafeMath #1559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nventuro
added
feature
nventuro
reviewed
Dec 17, 2018
frangio
commented
Dec 17, 2018
nventuro
reviewed
Dec 18, 2018
nventuro
reviewed
Dec 18, 2018
| it('reverts with a 0 divisor', async function () { | ||
| const a = new BigNumber(5678); | ||
| const b = new BigNumber(0); | ||
| describe('div', function () { |
There was a problem hiding this comment.
Unsigned integer division has a couple more tests this one is missing, should we add them?
|
Created #1563 to merge this as-is for 2.1 and improve testing afterwards. |
|
Please add this to the changelog. |
…y into signed-safe-math
|
PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #835.
Fixes #705.
This PR includes @facuspagnuolo's code and tests from #835 with @cag's fix from facuspagnuolo#1. I've also reviewed @cag's proofs that the math doesn't overflow in #835 (comment) and they seem correct to me.