Hardcode ERC777 granularity to 1, remove tests. #1739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we ever bring back the granularity we should remember that the tests for it were already written. |
nventuro
added a commit
that referenced
this pull request
May 8, 2019
* Hardcode ERC777 granularity to 1, remove tests. * Add clarifying title comment. (cherry picked from commit 376820d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1735, the
ERC777contract will have the granularity hardcoded to 1: we'll be providing a mixin down the line (if there's demand for it) that enables support for arbitrary granularities.