Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test-helpers to v0.4.0. #1770

Merged
merged 1 commit into from May 24, 2019
Merged

Update test-helpers to v0.4.0. #1770

merged 1 commit into from May 24, 2019

Conversation

nventuro
Copy link
Contributor

The new expectRevert makes the tests both more readable and harder to get wrong.

Fixes #1765

@nventuro nventuro added the tests Test suite and helpers. label May 24, 2019
@nventuro nventuro requested a review from frangio May 24, 2019 15:53
frangio
frangio approved these changes May 24, 2019
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nventuro nventuro merged commit a71c3bc into OpenZeppelin:master May 24, 2019
@nventuro nventuro deleted the update-test-helpers branch May 24, 2019 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio approved these changes

Assignees
No one assigned
Labels
tests Test suite and helpers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ERC20 test has a typo preventing it from working
2 participants
@nventuro @frangio