Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a wrong variable name in SampleCrowdsale.test.js. #916

Merged
merged 3 commits into from Jun 4, 2018
Merged

Fixed a wrong variable name in SampleCrowdsale.test.js. #916

merged 3 commits into from Jun 4, 2018

Conversation

duyoji
Copy link
Contributor

@duyoji duyoji commented Apr 24, 2018 •
edited by come-maiz

Fixes #968.

🚀 Description

I found unused variable name this.afterEnd and replaced it this.afterClosingTime.

come-maiz
come-maiz approved these changes May 29, 2018
View reviewed changes
Copy link
Contributor

@come-maiz come-maiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @duyoji! We were testing the wrong thing there. I've updated the branch, let's wait for the tests to be green and the second +1.

@duyoji
Copy link
Contributor Author

duyoji commented May 30, 2018

Thanks, @ElOpio !!

@shrugs shrugs merged commit 2a997a8 into OpenZeppelin:master Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-maiz come-maiz come-maiz approved these changes

@shrugs shrugs shrugs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@duyoji @come-maiz @shrugs