Formatting #924
Closed
Formatting #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure why there are two versions of "safeTransferFrom" with one having a _data var...
|
Hey @superphly, thanks for your PR, but this change comes from a rule in solium that deals with long args lists. We are discussing about replacing it with a rule for max-len: Feel free to leave your opinions there. I will close this PR, because this change breaks both rules :) Let's discuss in there to decide which one we should follow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why there are two versions of "safeTransferFrom" with one having a _data var...
Fixes #
🚀 Description
npm run lint:all:fix).