Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressed unchecked return value in AllowanceCrowdsale #945 using SafeERC20 #946

Conversation

dougiebuckets
Copy link
Contributor

@dougiebuckets dougiebuckets commented May 12, 2018

Fixes #945

🚀 Description

Addressed unchecked return value in AllowanceCrowdsale #945 using SafeERC20.

  • 📘 I've reviewed the OpenZeppelin Contributor Guidelines
  • ✅ I've added tests where applicable to test my new functionality.
  • 📖 I've made sure that my contracts are well-documented.
  • 🎨 I've run the JS/Solidity linters and fixed any issues (npm run lint:all:fix).

@come-maiz
Copy link
Contributor

Thank you @dougiebuckets. Can you please resolve the conflicts?
And Crowdsale.sol is also using transfer instead of safeTransfer. I think it would make sense to update it in this PR.

@dougiebuckets
Copy link
Contributor Author

@ElOpio - Thanks for the heads up! Should be all set.

Copy link
Contributor

@come-maiz come-maiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.
The reverts of safeTransferFrom are already tested, so I don't think we have to test the revert here again. But certainly that would be bonus points.
Leaving my +1, waiting for the opinion of the second reviewer.

@shrugs shrugs merged commit 39385f9 into OpenZeppelin:master Jun 9, 2018
@dougiebuckets dougiebuckets deleted the bug/unchecked-return-value-AllowanceCrowdsale-#945 branch June 9, 2018 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unchecked return value in AllowanceCrowdsale
3 participants