Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expectRevert does not return a transaction receipt #58

Open
nventuro opened this issue Jun 26, 2019 · 1 comment
Open

expectRevert does not return a transaction receipt #58

nventuro opened this issue Jun 26, 2019 · 1 comment

Comments

@nventuro
Copy link
Contributor

Reverted transactions still have a transaction receipt with has, used gas, etc.: we should return this object to the caller.

@frangio frangio added the good first issue Good for newcomers label Jun 26, 2019
@nventuro nventuro removed the good first issue Good for newcomers label Oct 8, 2019
@nventuro
Copy link
Contributor Author

nventuro commented Oct 8, 2019

The promise resolves to an error string: in order to get the receipt, we should use the PromiEvent event listeners (either error or promise). However, as is discussed in web3/web3.js#2612 and web3/web3.js#1859, on v1.2 of web3js a) receipt is not fired on failed transactions, and b) the receipt is not included on the error event.

This has been fixed on the 2.x branch, and will be backported to the 1.x soon (as part of the web3/web3.js#3070 initiative).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants