Skip to content
This repository has been archived by the owner on Nov 24, 2020. It is now read-only.

Issue Calling window.Intercom on beta signup form submission #13

Closed
siromivel opened this issue Mar 2, 2019 · 3 comments
Closed

Issue Calling window.Intercom on beta signup form submission #13

siromivel opened this issue Mar 2, 2019 · 3 comments

Comments

@siromivel
Copy link

siromivel commented Mar 2, 2019

Hey ZeppelinOS, I'm running into an issue submitting the beta signup form:
image

If noone else gets to it I'll take a look pulling the repo and opening a PR in the next few days here.

@siromivel
Copy link
Author

siromivel commented Mar 3, 2019

It looks like this is broken due a null value for REACT_APP_INTERCOM_APP_ID; by simply removing that check in index.js the form submission will work again as the missing ID is preventing Intercom from being injected.

That's probably undesirable as it will lead to emailing undefined@intercom-mail or similar unexpected behavior. I'm guessing a better fix would be to pass whatever the correct value is for that in the production environment.

@rrecuero
Copy link
Contributor

rrecuero commented Mar 3, 2019

Thank you. We just triggered a new deploy with the correct variable set :)

@rrecuero rrecuero closed this as completed Mar 3, 2019
@siromivel
Copy link
Author

siromivel commented Mar 4, 2019

@rrecuero Wanted to let you know that I just tried again and am encountering the same issue still.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants