Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defender.proposeUpgradeWithApproval: Rename approvalProcessId option #1008

Open
ericglau opened this issue Apr 11, 2024 · 0 comments
Open

defender.proposeUpgradeWithApproval: Rename approvalProcessId option #1008

ericglau opened this issue Apr 11, 2024 · 0 comments

Comments

@ericglau
Copy link
Member

For defender.proposeUpgradeWithApproval, the approvalProcessId option name is ambiguous. It is for customizing the upgrade approval process, not the deploy approval process.

Consider renaming the option to upgradeApprovalProcessId and deprecating (but still supporting) the old option name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ericglau