plugin-hardhat upgradeProxy upgradeTo call doesnt await receipt

[jacobrosenthal]

Weve largely had success with manual one off upgrades until when we started to script multiple upgrades at a time and kept getting

ProviderError: Transaction gas price supplied is too low. There is another transaction with same nonce in the queue. Try increasing the gas price or incrementing the nonce.

Adding an await receipt.wait(); after upgradeTo seemed to fix it for us
https://github.com/OpenZeppelin/openzeppelin-upgrades/blob/master/packages/plugin-hardhat/src/upgrade-proxy.ts#L37

But it seems like the codebase should be combed for other receipts it might be eating?

[frangio]

Thanks for reporting this issue!

We've purposely avoided unnecessarily waiting for transactions to mine, since it can introduce unwanted delays. In your case it seems like you want that delay, but the plugin doesn't give you any way to do that.

Something we could do is assign the upgrade transaction as the deployTransaction of the contract returned by upgradeProxy, similar to how we handle deployProxy.

openzeppelin-upgrades/packages/plugin-hardhat/src/deploy-proxy.ts

Line 84 in 0c2429c

inst.deployTransaction = deployTransaction;

If we did this you would be able to write

const v2 = await upgrades.upgradeProxy(proxyAddress, ImplV2);
await v2.deployed();

Would this work for you?

As a workaround, I think you should be able to use NonceManager to avoid resending a transaction with the same nonce, without the need to await in the middle.

[jacobrosenthal]

That might work. As you say, we tried deployed() with upstream and I know it didnt work or didnt exist.

It seems like .deployed() isnt really used much in favor of .deployTransaction.wait() but if thats the way to smuggle out the receipt wed give it a shot

[frangio]

Fixed in 1c92fb7#diff-b28b1ed9821f38c64524ea13e19264bb0772f8376afffd5d8a1f8277621833eb and released in the latest version of the Hardhat plugin.

@jacobrosenthal Please try it out and let me know. Both .deployed() and .deployTransaction.wait() should work.

[5hanth]

@frangio curious if this can help my use-case. I want to deploy the new implementation and store that TX that will be used for a Governance voting eventually by _authorizeUpgrade(address newImplementation) to check if the given implementation has enough votes to go through. so far it appears to me that there isn't a way to make the deployment of v2 first and call upgrateTo(newImplementationAddress) at a later stage once the proposal is revealed. Please correct me if I'm missing anything here. I see there is a way to attach new implementation with the new factory but the tests do not cover examples to upgrade to new implementation after attach

openzeppelin-upgrades/packages/plugin-hardhat/test/uups-happy-path.js

Line 21 in 6e5e7a4

const greeter3 = GreeterV3.attach(greeter3ImplAddr);

[Amxx]

Hello @5hanth

You can use the prepareUpgrade function. This will check the compatibility of the new implementation and deploy it to chain but NOT make the upgrade.

This function will return the instance of the newly deployed version.

You can then do you governance operation and perform the upgrade at a later stage.

[5hanth]

@Amxx Yes, I was planning in that approach. But for some reason calling MyContractV1.upgradeTo(implAddress) fails with reason Address: low-level delegate call failed. Is this not the native way of upgrading after prepareUpgrade via plugin?

[frangio]

If you're using transparent proxies (the default) you need to call the upgrade function of the ProxyAdmin contract. You can find the admin address in your .openzeppelin/mainnet.json file (or other network).

[5hanth]

@frangio I'm using UUPS

[frangio]

@5hanth Can you post your question on the OpenZeppeiln Forum? Include more details about how you have defined _authorizeUpgrade.

[5hanth]

I posted on OpenZeppelin. Just in case anyone wants to know this:

function _authorizeUpgrade(address newImplementation)
        internal
        override
        view
    {
        require(
            hasRole(DEFAULT_ADMIN_ROLE, msg.sender));
        require(approvedProposalsExpiry[newImplementation] > block.timestamp);
    }

signer has an admin role. The error occurs on reading any state variable.

[joaquinperea]

Hi guys! I'm deploying a proxy contract and its implementation using "deployProxy" instruction but I get a "Timed out waiting for transaction" error. I use ".deployed()" to await transaction mined but is not working. Am I doing something wrong?

[frangio]

@joaquinperea You're not doing anything wrong. If it times out, you can retry the same deployProxy function call and it will resume waiting for the same transaction.

[zhibo-noumena]

Hello,

It seems now deployed() is deprecated, I am using await .waitForDeployment(), and it still returns before the contract getting upgraded.