Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error when retype/rename annotation is wrong #727

Open
frangio opened this issue Jan 26, 2023 · 0 comments
Open

Show error when retype/rename annotation is wrong #727

frangio opened this issue Jan 26, 2023 · 0 comments

Comments

@frangio
Copy link
Contributor

frangio commented Jan 26, 2023

If the user gets the annotation slightly wrong, it's simply ignored. For example writing /// @custom:oz-retyped-from TheStruct instead of ...-from TheContract.TheStruct.

If there is a retyped/renamed annotation we should enforce that it matches what the previous name or type was.

This may be a new type of layout error, say bad-annotation that we emit if there is an annotation and it doesn't match what we'd expect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant