Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show stacktrace for unsafe delegatecall/selfdestruct errors #762

Open
ericglau opened this issue Mar 22, 2023 · 0 comments
Open

Show stacktrace for unsafe delegatecall/selfdestruct errors #762

ericglau opened this issue Mar 22, 2023 · 0 comments

Comments

@ericglau
Copy link
Member

If a contract directly or indirectly depends on some code that has a delegatecall or selfdestruct, the plugin gives an error like:

 Error: Contract `contracts/MyContract.sol:MyContract` is not upgrade safe

@openzeppelin/contracts/utils/Address.sol:191: Use of delegatecall is not allowed
    https://zpl.in/upgrades/error-002

It would be helpful to show a stacktrace including the line in MyContract and intermediate contracts that led to the unsafe code, so that the user can determine if they should fix the issue or add an ignore annotation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant