Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim bytecode whitespace when hashing #834

Closed
wants to merge 1 commit into from
Closed

Trim bytecode whitespace when hashing #834

wants to merge 1 commit into from

Conversation

frangio
Copy link
Contributor

@frangio frangio commented Jul 4, 2023

Fixes #823

Note: This is backwards compatible because any whitespace that is present would cause the hex check to fail, rather than change the resulting hash.

@frangio frangio requested a review from ericglau July 4, 2023 20:49
@frangio frangio marked this pull request as draft July 4, 2023 20:51
@frangio frangio closed this Jul 4, 2023
@frangio
Copy link
Contributor Author

frangio commented Jul 4, 2023

Hm, I'm having doubts that this is the issue behind #823. There should never be whitespace here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The upgradeProxy fails with "Bytecode is not a valid hex string"
1 participant