Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 5.x proxy artifact paths in next major version of upgrades-core #931

Open
ericglau opened this issue Nov 30, 2023 · 0 comments
Open

Update 5.x proxy artifact paths in next major version of upgrades-core #931

ericglau opened this issue Nov 30, 2023 · 0 comments
Labels
breaking change Changes that break backwards compatibility of the public API.

Comments

@ericglau
Copy link
Member

ericglau commented Nov 30, 2023 •
edited
Loading

The @openzeppelin/upgrades-core package includes precompiled proxy artifacts from OpenZeppelin Contracts 4.x at /artifacts/@openzeppelin/contracts/proxy/.

To maintain backwards compatibility, proxy artifacts from OpenZeppelin Contracts 5.x are packaged at /artifacts/@openzeppelin/contracts-v5/proxy

For the next major version of upgrades-core, consider changing these paths to place 5.x proxy artifacts at the default paths. Consider removing the legacy 4.x artifacts if they are no longer needed (the bytecodes are only for deployments, and only a small portion of their ABIs are used in the Hardhat Plugin in packages/plugin-hardhat/src/utils/attach-abi.ts which can be hardcoded if needed).
@ericglau ericglau added the breaking change Changes that break backwards compatibility of the public API. label Nov 30, 2023
@ericglau ericglau mentioned this issue Nov 30, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change Changes that break backwards compatibility of the public API.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ericglau