ERC721 contracts no longer initialize their parents. #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue with diamonds in the ERC721 inheritance tree (namely, having to pass
name
andsymbol
multiple times toMetadataMintable
). Initializer for all parents have to be manually called (the mocks are an example of this).Since we'll be providing a metadata, enumerable, mintable and pausable standalone ERC721 as part of our EVM package, this shouldn't be too bad, thought I'm not thrilled that initializers forced us to go this way.
I've also added some initialization safety checks in the style of #27.