Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERC20 approve problem #168

Closed
maraoz opened this issue Mar 20, 2017 · 2 comments
Closed

ERC20 approve problem #168

maraoz opened this issue Mar 20, 2017 · 2 comments
Labels
bug

Comments

@maraoz
Copy link
Contributor

maraoz commented Mar 20, 2017

See https://drive.google.com/file/d/0ByMtMw2hul0EN3NCaVFHSFdxRzA/view
@maraoz maraoz added the bug label Mar 20, 2017
@maraoz maraoz mentioned this issue Mar 28, 2017
Closed
@izqui
Copy link
Contributor

izqui commented Apr 4, 2017

I like this simple approach to solving it

https://github.com/Giveth/minime/blob/master/contracts/MiniMeToken.sol#L253

@frangio
Copy link
Contributor

frangio commented Apr 4, 2017 •
edited

I like it too! It has the benefit that the token remains ERC20 compliant.

There's still the related issue of logging who initiated a transferFrom operation (the "spender").

@miohtama miohtama mentioned this issue May 16, 2017
Merged
@maraoz maraoz closed this as completed May 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@maraoz @izqui @frangio