Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement page translation fallback #718

Conversation

nlubisch
Copy link
Member

1. Why is this change necessary?

2. What does this change do, exactly?

3. Describe each step to reproduce the issue or behaviour.

4. Please link to the relevant issues (if any).

5. Checklist

  • I have written tests and verified that they fail without my change
  • I have squashed any insignificant commits
  • This change has comments for package types, values, functions, and non-obvious lines of code

@nlubisch nlubisch force-pushed the feature/implement-page-translation-fallback branch from 4c6bfd1 to d584e19 Compare May 27, 2018 17:27
@codecov
Copy link

codecov bot commented May 27, 2018

Codecov Report

Merging #718 into development will increase coverage by <.01%.
The diff coverage is 7.59%.

Impacted file tree graph

@@              Coverage Diff               @@
##           development    #718      +/-   ##
==============================================
+ Coverage         5.43%   5.44%   +<.01%     
==============================================
  Files              257     259       +2     
  Lines            15997   16056      +59     
==============================================
+ Hits               870     874       +4     
- Misses           15127   15182      +55
Impacted Files Coverage Δ
htdocs/src/Oc/Page/Persistence/BlockEntity.php 100% <ø> (ø)
htdocs/src/Oc/Page/Persistence/BlockService.php 100% <ø> (ø)
htdocs/src/Oc/Page/Persistence/BlockRepository.php 0% <ø> (ø)
htdocs/src/Oc/Page/Persistence/PageEntity.php 100% <ø> (ø)
htdocs/src/Oc/Page/Persistence/PageRepository.php 0% <ø> (ø)
htdocs/src/Oc/Page/Persistence/PageService.php 100% <ø> (ø)
htdocs/src/Oc/Page/PageProvider.php 0% <0%> (ø)
htdocs/src/Oc/Page/Controller/PageController.php 0% <0%> (ø) ⬆️
...src/Oc/GlobalContext/Provider/LanguageProvider.php 90.9% <0%> (-9.1%) ⬇️
htdocs/src/Oc/Page/PageStruct.php 0% <0%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b626b0d...d584e19. Read the comment docs.

@teiling88 teiling88 merged commit ff940ae into OpencachingDeutschland:development May 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants