Feature/import gc logs #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teiling88
force-pushed
the
feature/import-gc-logs
branch
from
d392f38
to
569faff
Compare
Codecov Report
@@ Coverage Diff @@
## development #720 +/- ##
==============================================
- Coverage 5.44% 5.43% -0.01%
==============================================
Files 259 260 +1
Lines 16056 16073 +17
==============================================
Hits 874 874
- Misses 15182 15199 +17
Continue to review full report at Codecov.
|
nlubisch
requested changes
Aug 10, 2018
htdocs/composer.json
Outdated
| @@ -25,7 +25,7 @@ | |||
| "opencaching/okapi": "dev-master", | |||
| "opencaching/kitchensink-bundle": "1.0.6", | |||
| "endroid/qrcode": "^2.4", | |||
| "twbs/bootstrap": "^v4.0.0", | |||
| "twbs/bootstrap": "v4.0.0-beta.2", | |||
| /** @var int */ | ||
| public $geocacheId; | ||
|
|
||
| /** @var smallint */ |
| /** @var int */ | ||
| public $cacheId; | ||
|
|
||
| /** @var char */ |
| */ | ||
| public function isNew() | ||
| { | ||
| return $this->id=== null; |
There was a problem hiding this comment.
space missing before comparison characters
| /** @var char */ | ||
| public $language; | ||
|
|
||
| /** @var longtext */ |
| /** @var DateTime */ | ||
| public $expires; | ||
|
|
||
| /** @var mediumblob */ |
| public $serviceName; | ||
|
|
||
| /** @var enum */ | ||
| public $calltype; |
| /** @var string */ | ||
| public $currentLogName; | ||
|
|
||
| /** @var bigint */ |
| /** @var string */ | ||
| public $resourceName; | ||
|
|
||
| /** @var mediumint */ |
local/devel/Entities/UserEntity.php
Outdated
| /** @var string */ | ||
| public $password; | ||
|
|
||
| /** @var binary */ |
teiling88
force-pushed
the
feature/import-gc-logs
branch
from
569faff
to
1909b95
Compare
teiling88
force-pushed
the
feature/import-gc-logs
branch
from
e1f0dde
to
00a4196
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this change necessary?
2. What does this change do, exactly?
3. Describe each step to reproduce the issue or behaviour.
4. Please link to the relevant issues (if any).
5. Checklist