Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translations and encoding on testserver #818

Conversation

sdennler
Copy link
Collaborator

1. Why is this change necessary?

Translations on the testserver (http://docker.team-opencaching.de) work only partialy and when creating a new GeoCache, the attributes are not selectable.

⚠️ The changes in this PR did make it work on my machine - more tests on other machines are needed. ⚠️

2. What does this change do, exactly?

  • Install gettext
  • Configure the correct user for docker "application" instead of "vagrant"
  • Set the default character-set for the connection to MariaDB to "utf8mb4"

3. Describe each step to reproduce the issue or behaviour.

  1. Install the testserver (from scratch?)
  2. Open http://docker.team-opencaching.de
  3. Try to switch the language -> It won't work
  4. Try to switch the country -> The list is empty on most pages and incomplete on some.
  5. Try to create a new GeoCache and select a Attribute -> it wont work

4. Please link to the relevant issues (if any).

https://opencaching.atlassian.net/browse/RED-1278

5. Checklist

  • I have written tests and verified that they fail without my change
  • I have squashed any insignificant commits
  • This change has comments for package types, values, functions, and non-obvious lines of code

@teiling88
Copy link
Member

Looks good and worked on my docker instance, too.

Great work!!

@teiling88 teiling88 merged commit 670cb80 into OpencachingDeutschland:development Feb 17, 2021
@MacGyver-NRW
Copy link
Member

Thanks for fixing @sdennler :)
Work approved and doing well.

@sdennler sdennler deleted the fix/translations--on-testserver branch April 25, 2021 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Legacy Legacy Code Changes Translation
Projects
None yet
3 participants