fix(hardware): add hepa uv to tool detector #15001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfoster1
approved these changes
Apr 24, 2024
| pipette_name.name, | ||
| f"dummyserial{pipette_name.name}", | ||
| pipette_name, |
There was a problem hiding this comment.
oof. can we change this to use kwargs like pipette_name= instead of positional?
caila-marashaj
force-pushed
the
parse-hepa-uv-response
branch
from
9844eea
to
270989b
Compare
vegano1
approved these changes
May 22, 2024
caila-marashaj
changed the title
ryanthecoder
pushed a commit
that referenced
this pull request
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the hepa/uv device is sending responses after an
InstrumentInfoRequest, but the tool detector code isn't set up to parse these messages, meaning that the queue doesn't get properly emptied, and the instrument info responses keep coming in