refactor(api): Emit proper comment commands from legacy protocols
#15419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxColoring
force-pushed
the
more_real_comments
branch
from
c735c5a
to
dcf96d7
Compare
SyntaxColoring
added
api
SyntaxColoring
changed the title
comment commands from legacy protocols.comment commands from legacy protocols
TamarZanzouri
approved these changes
Jun 14, 2024
|
Accidentally closed this. Replaced by PR #15426. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
For historical reasons, Python Protocol API
ProtocolContext.comment("...")s have always been reported as "legacy"customcommands in the analysis engine and HTTP API. #15408 changes them to proper Protocol Enginecommentcommands when the Python protocol hasapiLevel≥2.14. This PR makes the same change for Python protocols withapiLevel≤2.13, just for the sake of uniformity.Test Plan
I'll test this in #15409.
Review requests
None in particular.
Risk assessment
Low.