Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(*): OpenTrons -> Opentrons; v3a -> edge #1704

Merged
merged 1 commit into from Jun 15, 2018

Conversation

IanLondon
Copy link
Contributor

#1701 reminded me that some OpenTrons not Opentrons lines still exist -- they're mostly in the outdated API docs, but I fixed the ones in PD.

Also tossed in changing the last remaining v3a to edge in PULL_REQUEST_TEMPLATE.

@mcous is it OK to edit PD's CHANGELOG like this? Or should I leave CHANGELOG and just change package.json, and it will correct it when it builds the next CHANGELOG?

Copy link
Contributor

@mcous mcous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏗

Almost certain this changelog edit will persist. Pretty sure lerna/conventional-changelog only appends, not regenerates

@codecov
Copy link

codecov bot commented Jun 15, 2018

Codecov Report

Merging #1704 into edge will decrease coverage by 1.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             edge    #1704     +/-   ##
=========================================
- Coverage   34.91%   33.81%   -1.1%     
=========================================
  Files         339      343      +4     
  Lines        5553     5754    +201     
=========================================
+ Hits         1939     1946      +7     
- Misses       3614     3808    +194
Impacted Files Coverage Δ
protocol-designer/src/file-data/reducers/index.js 37.5% <0%> (-2.5%) ⬇️
protocol-designer/src/containers/Alerts.js 0% <0%> (ø) ⬆️
...rotocol-designer/src/containers/LabwareDropdown.js 0% <0%> (ø) ⬆️
protocol-designer/src/navigation/reducers/index.js 0% <0%> (ø) ⬆️
app/src/components/JogControls/index.js 0% <0%> (ø) ⬆️
...rotocol-designer/src/components/IngredientsList.js 0% <0%> (ø) ⬆️
...col-designer/src/containers/LabwareNameEditForm.js 0% <0%> (ø) ⬆️
app/src/components/ChangePipette/index.js 0% <0%> (ø) ⬆️
protocol-designer/src/svg/CopyIcon.js 0% <0%> (ø) ⬆️
app/src/pages/Robots.js 0% <0%> (ø) ⬆️
... and 89 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02cb7e3...9c47e44. Read the comment docs.

@IanLondon IanLondon merged commit 90f51d8 into edge Jun 15, 2018
@IanLondon IanLondon deleted the chore_update-repo-names branch June 15, 2018 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants