Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(app) Chore: add flow and flowconfig to app #507

Closed
wants to merge 1 commit into from
Closed

Conversation

mcous
Copy link
Contributor

@mcous mcous commented Dec 14, 2017

In a holding pattern on this one; it may be simply dropped in favor of #508 if we can get it in quickly enough

overview

Adds flow and necessary setup to the app and app documentation.

This PR includes:

  • Chore work
  • Bug fixes
  • Backwards-compatible feature additions
  • Breaking changes
  • Documentation updates
  • Test updates

changelog

  • (Chore) Added flow and flow configuration to the app
  • (Refactor) Renamed the types directory in components to interfaces

review requests

Please test things out on your machines. @IanLondon we can also throw protocol designer in on this PR, too; lemme know.

@mcous mcous added app Affects the `app` project chore ready for review labels Dec 14, 2017
@codecov
Copy link

codecov bot commented Dec 14, 2017

Codecov Report

Merging #507 into v3a will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              v3a     #507   +/-   ##
=======================================
  Coverage   72.02%   72.02%           
=======================================
  Files         139      139           
  Lines        4879     4879           
  Branches        1        1           
=======================================
  Hits         3514     3514           
  Misses       1365     1365

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc23927...af4bac0. Read the comment docs.

@mcous mcous added blocked Ticket or PR is blocked by other work and removed ready for review labels Dec 14, 2017
@mcous mcous mentioned this pull request Dec 14, 2017
2 tasks
@mcous mcous closed this Dec 20, 2017
@mcous mcous deleted the app_add-flow branch December 20, 2017 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Affects the `app` project blocked Ticket or PR is blocked by other work chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant