Only send slack invite after user verifies email #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…firmation callback
|
I'll have the test issue fixed in a moment. |
Instead of running upon the account being registered, the slack invite is sent when the email is verified. The existing test has been changed to anticipate the slack invite no longer being sent on on registration and a new test has been added to check for the test when the email has been verified.
|
Code Climate has analyzed commit fffe6f8 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 99.4%. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Before the slack invites were sent when the user registers their email, but now will be sent after the email is verified. This ensures only users with valid email addresses (and not parked or fake accounts) get invited to slack.
Issue Resolved
Fixes #359