Fix map controls (+, -) and map view on desktop #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
anishagg17
reviewed
Dec 23, 2019
| @@ -0,0 +1,59 @@ | |||
| .map-view iframe { | |||
There was a problem hiding this comment.
Duplicate of
https://github.com/fossasia/summit.fossasia.org/pull/28/files
You have copied everything from my pull request
There was a problem hiding this comment.
Thanks for the review. In Open Source using existing code is fine, but the author should be referenced. Please do this next time.
There was a problem hiding this comment.
I'm sorry you feel this way but I just referenced the code from the current existing map-holder class in the camaro.less file. I realized using plain css would be better than less syntax and updated it with a new class map-view. I also added media-query css rule to update view for mobile with the position attribute.
mariobehling
approved these changes
Dec 23, 2019
|
Thank you for merging the request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This is to fix issue #9 and the current desktop map view.
Process
Created new css class for map view and updated it with new options. Changed class of current map view to new class which allowed controls to work. Added css rule using media query to allow mobile to work as well.
Preview
View the working +/- controls and updates at https://pranavkarthik10.github.io/opentechsummit.eu/
Before
After