Update .luacheckrc

.luacheckrc

@@ -3,15 +3,9 @@ max_line_length = false
 exclude_files = {
 	"**/Libs",
 }
-only = {
-	"011", -- syntax
-	"1", -- globals
-}
 ignore = {
-	"11/SLASH_.*", -- slash handlers
-	"1/[A-Z][A-Z][A-Z0-9_]+", -- three letter+ constants
+	"212", -- Unused argument
 }
-
 globals = {
 	"LibStub",
 	"UpdateOnBarHighlightMarksBySpell",

Core.lua

@@ -36,9 +36,9 @@ do
 			elseif searchType == "parentFrames" then
 				text = self:GetMouseoverFramesText()
 			elseif searchType == "mouseFocus" then
-				local frame = GetMouseFocus()
-				if frame and frame ~= WorldFrame then
-					text = self:GetSpecificFrameText(frame)
+				local focusFrame = GetMouseFocus()
+				if focusFrame and focusFrame ~= WorldFrame then
+					text = self:GetSpecificFrameText(focusFrame)
 				end
 			else
 				self:Print(L.invalidSearchType:format(searchType))

FontStringFinder.lua

@@ -48,7 +48,7 @@ do
 	    local frame = EnumerateFrames()
 	    while frame do
 	        local regions = { frame:GetRegions() }
-	        for i, region in next, regions do
+	        for _, region in next, regions do
 	            -- much faster to check if GetText than to use GetObjectType and check if FontString
 	            if region.GetText and condition(region) then
 	                fontStrings[#fontStrings+1] = region
@@ -123,21 +123,15 @@ do
 	end
 end
 
-do
-	local function filter(fontString)
-		return fontString:IsVisible()
-	end
-
-	-- Returns all text from all frames under the cursor.
-	-- @return string containing all text from frames under the cursor.
-	function addon:GetMouseoverFramesText()
-		local frames = self:GetMouseoverFrames()
-		local texts = {}
-		for _, frame in ipairs(frames) do
-			texts[#texts+1] = self:GetSpecificFrameText(frame)
-		end
-		return table.concat(texts, "\n")
+-- Returns all text from all frames under the cursor.
+-- @return string containing all text from frames under the cursor.
+function addon:GetMouseoverFramesText()
+	local frames = self:GetMouseoverFrames()
+	local texts = {}
+	for _, frame in ipairs(frames) do
+		texts[#texts+1] = self:GetSpecificFrameText(frame)
 	end
+	return table.concat(texts, "\n")
 end
 
 --------------------------------------------------------------------------------
@@ -186,11 +180,11 @@ end
 function addon:FontStringsToString(fontStrings)
     local texts = {}
 	local foundOne = false
-    for i, f in ipairs(fontStrings) do
-		local text = f:GetText()
+    for _, fs in ipairs(fontStrings) do
+		local text = fs:GetText()
 		if text then
 			foundOne = true
-        	texts[#texts+1] = text
+			texts[#texts+1] = text
 		end
     end
     return foundOne and table.concat(texts, "\n")

TableUtils.lua

@@ -55,7 +55,7 @@ end
 -- @return Reduced value.
 function tableUtils.Reduce(t, reducer)
 	local accumulator = nil
-	for i, current in ipairs(t) do
+	for _, current in ipairs(t) do
 		accumulator = reducer(accumulator, current)
 	end
 	return accumulator