Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't version demo pages outputs #43

Merged
merged 2 commits into from
Dec 7, 2022
Merged

Conversation

zapo
Copy link
Member

@zapo zapo commented Dec 7, 2022

Those shouldn't be versionned as they are generated by the pipeline.
Also fix the circleci pipeline to pass down config envs exported (since that's what the Makefile expects right now... this should be cleaned up eventually).

@zapo zapo requested a review from ratelle December 7, 2022 17:31
Copy link

@ab116699 ab116699 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zapo zapo merged commit fc63fcf into master Dec 7, 2022
@zapo zapo deleted the dont-version-demos-outputs branch December 7, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants