Support for ConversionUploadService

[ellisonc]

The google ads documentation shows the ConversionUploadService as having endpoints for UploadCallConversions() and UploadClickConversions() which accept an array of conversions and support partial_failures. The typescript definitions for this client library suggest that only one conversion is accepted at a time:

customer.conversionUploads.uploadClickConversion(conversion: ClickConversion)
customer.conversionUploads.uploadCallConversion(conversion: CallConversion)

Should these not be more like as follows?

customer.conversionUploads.uploadClickConversions(conversions: Array, options?: ServiceCreateOptions)

[avermeil]

You're right, that doesn't look quite right.

We don't yet properly looked at the conversion upload functionality (no tests either), so it's very possible that it doesn't work quite right. I expect we'll get around to implementing it properly in the next few weeks, after we get some reference documentation published.

In general, most functions outside of get and mutate service methods are still todos.

PRs welcome ;)

[leongrin]

Please update this post when the ConversionUploadService is ready. Uploading offline conversions is a very important aspect of the app we are building.
Thank you.

[avermeil]

Hi @leongrin,

We're a bit short on time to work on this feature at the moment. Would you consider helping out with a PR?

[leongrin]

Unfortunately I don't have the technical knowledge to help with this issue.

[arditti]

Any updates on this one? my implementation is meaningless without this feature.
Do you need any technical help implementing this feature?

[kritzware]

Hi @arditti, sorry for the delay on this one!

We've been waiting for the new v3 release of the API before continuing with this feature, as v3 may require some changes to the underlying google-ads-node library e.g. such as implementing streaming.

[arditti]

@kritzware really appreciate the quick response.
regarding v3, are we excepting any api breaking changes? or its just "under-the-hood" release?

[kritzware]

I expect it to not effect the API. Streaming will most likely be a new report method, or optionally available via a feature flag (keeping customer.report the same as it is currently).

[Joel-Valentine]

Hey @ellisonc we added this in v3.6.0. We aren't entirely sure if this works correctly. Please let us know how you get on