fix: call Queue.isReady() before job promote is called #1619
Conversation
1 similar comment
|
I test it at my local machine, and it works well. |
| } | ||
| }); | ||
| return queue.isReady().then(() => | ||
| scripts.promote(queue, jobId).then(result => { |
There was a problem hiding this comment.
a return is needed here so that the promise returned by promote is propagated correctly.
There was a problem hiding this comment.
Hello @manast , do you mean the following part of the code
... .then(() => scripts.promote() ...)
if yes then in es6 the syntax () => value is identical to () => { return value } so it is practically like writing
return queue.isReady().then(() => { return scripts.promote(queue, jobId) }).then() ...
If this is not what you meant please correct me
There was a problem hiding this comment.
however if you would like to use the previous syntax () => {return ...} (which as i can see is used in this file) then i can edit my pr
There was a problem hiding this comment.
no sorry, the code is correct, I did not notice the arrow function.
The issue is described here: #1231