Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev update transformers #616

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Dev update transformers #616

merged 2 commits into from
Aug 11, 2023

Conversation

yaoguany
Copy link
Collaborator

Copy link
Contributor

@research4pan research4pan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we may fix the issues caused by this transformers version update later. Currently main branch is not stable, we recommend everyone to use v0.0.5 for now.

Potential issues

  1. CUDA_VISIBLE_DEVICES issue: CUDA_VISIBLE_DEVICES is not respected in latest deepspeed==0.10.0. Please specify gpus with fashion such as deepspeed --include localhost:0,1,2,3.
  2. hf/deepspeed scheduler optimizer combo issue: hf scheduler + ds optimizer is no longer supported according to restriction in transformers after version 4.29.2. This update happens in transformers==4.29.2 to transformers==4.30.0
  3. qlora multi-GPU issue: qlora currently may not support multiple GPUs.
  4. qlora merging issue: qlora currently may not support merging into original model.
  5. deepspeed zero3 issue: need modify some parts of configs/ds_config_zero3.json to smoothly utilize zero optimization stage 3 in deepspeed after update.

README.md

  • [Style] use bash install.sh is okay. As we have shebang line in install.sh, the original usage is also okay.

@research4pan research4pan merged commit 4895d18 into main Aug 11, 2023
2 checks passed
@research4pan research4pan deleted the dev-update-transformers branch March 31, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants