Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New feature] Integrate DPO #759

Merged
merged 5 commits into from
Apr 28, 2024
Merged

[New feature] Integrate DPO #759

merged 5 commits into from
Apr 28, 2024

Conversation

gzliyu
Copy link
Contributor

@gzliyu gzliyu commented Apr 11, 2024

./scripts/run_dpo_align.sh \
  --model_name_or_path /home/nlpintern1/liyu/models/0313_sft_llama_full \
  --dataset_path /home/nlpintern1/liyu/dataset/stack-exchange-paired/data \
  --output_lora_path output_models/dpo_lora

Copy link
Contributor

@research4pan research4pan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole framework looks good to me, Thanks! Some improvements can be made in later commits.

scripts/run_dpo_align.sh

  • Line 6: we may specify no cuda visible devices, as some users may want to run on single gpus.
  • Line 7: maybe meta-llama/Llama-2-7b-hf instead.
  • Line 8: I am wondering if this dataset is available in LMFlow data server?
  • Line 10: Same as Line 6.

@research4pan
Copy link
Contributor

Let's wait for more tests before it can be merged into main, maybe merged into a feature branch first.

@wheresmyhair wheresmyhair mentioned this pull request Apr 28, 2024
@research4pan research4pan merged commit 8a70f48 into OptimalScale:main Apr 28, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants