Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in trusted advisor for multiple roles given overwriting each other #10

Merged
merged 2 commits into from
Jun 23, 2021

Conversation

bjfish25
Copy link
Contributor

Proposed changes

This bug fixes an issue where multiple roles are given, the latest overwrites the previous.

Issues for these changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (changes to code, which do not change application behavior)

Checklist

  • I have filled out this PR template
  • I have read the CONTRIBUTING doc
  • I have added automated tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (README.md, CHANGELOG.md, etc. - if appropriate)

Dependencies and Blockers

Relevant Links

Further comments

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@bjfish25 bjfish25 merged commit 00287ab into master Jun 23, 2021
@bjfish25 bjfish25 deleted the bug-fix/multi-role-ta branch June 23, 2021 15:47
@github-actions
Copy link

Unit Test Results

    2 files  ±0      2 suites  ±0   10s ⏱️ ±0s
249 tests ±0  249 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 00287ab. ± Comparison against base commit 5922523.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants