Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fix for trusted advisor metadata coming in unexpected order #14

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

bjfish25
Copy link
Contributor

@bjfish25 bjfish25 commented Sep 1, 2021

Proposed changes

It was possible for there to only be 2 metadata fields which was spitting out null-resource errors. This PR fixes this issue by more dynamically checking for the region.

Issues for these changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (changes to code, which do not change application behavior)

Checklist

  • I have filled out this PR template
  • I have read the CONTRIBUTING doc
  • I have added automated tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (README.md, CHANGELOG.md, etc. - if appropriate)

Dependencies and Blockers

Relevant Links

Further comments

@bjfish25 bjfish25 self-assigned this Sep 1, 2021
@github-actions

This comment has been minimized.

@bjfish25 bjfish25 merged commit e4e07f3 into master Sep 2, 2021
@bjfish25 bjfish25 deleted the bug-fix/trustedadvisor-metadata branch September 2, 2021 13:58
@github-actions
Copy link

github-actions bot commented Sep 2, 2021

Unit Test Results

    2 files  ±0      2 suites  ±0   10s ⏱️ ±0s
255 tests ±0  255 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e4e07f3. ± Comparison against base commit 8bad266.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants